[PATCH v2 2/2] fscache: Add the missing smp_mb__after_atomic() before wake_up_bit()

David Howells dhowells at redhat.com
Thu Jan 12 03:24:59 AEDT 2023


David Howells <dhowells at redhat.com> wrote:

> What two values are you ordering?
> 
> If we're using this to create a critical section, then yes, we would need a
> barrier to order the changes inside the critical section before changing the
> memory location that forms the lock - but this is not a critical section.

Actually, that said, the ordering is probably between the bit being cleared
and the task state.

David



More information about the Linux-erofs mailing list