[PATCH v6 2/3] erofs-utils: update on-disk format for xattr name filter

Jingbo Xu jefflexu at linux.alibaba.com
Wed Aug 30 00:19:03 AEST 2023



On 8/29/23 8:49 PM, Gao Xiang wrote:
> 
> 
> On 2023/8/29 20:41, Jingbo Xu wrote:
>> The xattr name bloom filter feature is going to be introduced to speed
>> up the negative xattr lookup, e.g. system.posix_acl_[access|default]
>> lookup when running "ls -lR" workload.
> 
> 
> I think you could just say
> "Let's keep in sync with kernel commit <12-char commit id>."
> 
> here.
> 
> ...
> 
>> ---
> 
> 
> ...
> 
>> +#define EROFS_XATTR_NAME_LEN_MAX    UCHAR_MAX
> 
> where is EROFS_XATTR_NAME_LEN_MAX used?

Indeed it's not used and I can't remember where it's used in the initial
implementation...

I will drop it later.

-- 
Thanks,
Jingbo


More information about the Linux-erofs mailing list