[xiang-erofs:dev-test 5/6] fs/erofs/fscache.c:535:23: warning: no previous prototype for function 'erofs_fscache_acquire_cookie'
kernel test robot
lkp at intel.com
Sun Sep 18 18:02:57 AEST 2022
tree: https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git dev-test
head: 73ac9605cc83179e0d44a8c64d85ab81d5d7a57e
commit: 0c8acee18add4f65597f6a2a3111256bee50ffc8 [5/6] erofs: Support sharing cookies in the same domain
config: hexagon-randconfig-r025-20220918 (https://download.01.org/0day-ci/archive/20220918/202209181550.IB5iSy64-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git/commit/?id=0c8acee18add4f65597f6a2a3111256bee50ffc8
git remote add xiang-erofs https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git
git fetch --no-tags xiang-erofs dev-test
git checkout 0c8acee18add4f65597f6a2a3111256bee50ffc8
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash fs/erofs/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp at intel.com>
All warnings (new ones prefixed by >>):
>> fs/erofs/fscache.c:535:23: warning: no previous prototype for function 'erofs_fscache_acquire_cookie' [-Wmissing-prototypes]
struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
^
fs/erofs/fscache.c:535:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
^
static
1 warning generated.
vim +/erofs_fscache_acquire_cookie +535 fs/erofs/fscache.c
534
> 535 struct erofs_fscache *erofs_fscache_acquire_cookie(struct super_block *sb,
536 char *name, bool need_inode)
537 {
538 struct fscache_volume *volume = EROFS_SB(sb)->volume;
539 struct erofs_fscache *ctx;
540 struct fscache_cookie *cookie;
541 int ret;
542
543 ctx = kzalloc(sizeof(*ctx), GFP_KERNEL);
544 if (!ctx)
545 return ERR_PTR(-ENOMEM);
546
547 cookie = fscache_acquire_cookie(volume, FSCACHE_ADV_WANT_CACHE_SIZE,
548 name, strlen(name), NULL, 0, 0);
549 if (!cookie) {
550 erofs_err(sb, "failed to get cookie for %s", name);
551 ret = -EINVAL;
552 goto err;
553 }
554
555 fscache_use_cookie(cookie, false);
556 ctx->cookie = cookie;
557
558 if (need_inode) {
559 struct inode *const inode = new_inode(sb);
560
561 if (!inode) {
562 erofs_err(sb, "failed to get anon inode for %s", name);
563 ret = -ENOMEM;
564 goto err_cookie;
565 }
566
567 set_nlink(inode, 1);
568 inode->i_size = OFFSET_MAX;
569 inode->i_mapping->a_ops = &erofs_fscache_meta_aops;
570 mapping_set_gfp_mask(inode->i_mapping, GFP_NOFS);
571
572 ctx->inode = inode;
573 }
574
575 return ctx;
576
577 err_cookie:
578 fscache_unuse_cookie(ctx->cookie, NULL, NULL);
579 fscache_relinquish_cookie(ctx->cookie, false);
580 err:
581 kfree(ctx);
582 return ERR_PTR(ret);
583 }
584
--
0-DAY CI Kernel Test Service
https://01.org/lkp
More information about the Linux-erofs
mailing list