Jingbo Xu <jefflexu at linux.alibaba.com> wrote: > + if (test_bit(FSCACHE_REQ_COPY_TO_CACHE, &flags)) > + __set_bit(NETFS_SREQ_COPY_TO_CACHE, &subreq->flags); Please don't do that in netfslib. Netfslib shouldn't know about fscache's inner workings. David