[PATCH] erofs: fix crash when enable tracepoint cachefiles_prep_read

Chao Yu chao at kernel.org
Sun May 29 16:08:54 AEST 2022


On 2022/5/27 18:18, Xin Yin wrote:
> RIP: 0010:trace_event_raw_event_cachefiles_prep_read+0x88/0xe0
> [cachefiles]
> Call Trace:
>    <TASK>
>    cachefiles_prepare_read+0x1d7/0x3a0 [cachefiles]
>    erofs_fscache_read_folios+0x188/0x220 [erofs]
>    erofs_fscache_meta_readpage+0x106/0x160 [erofs]
>    do_read_cache_folio+0x42a/0x590
>    ? bdi_register_va.part.14+0x1a7/0x210
>    ? super_setup_bdi_name+0x76/0xe0
>    erofs_bread+0x5b/0x170 [erofs]
>    erofs_fc_fill_super+0x12b/0xc50 [erofs]
> 
> This tracepoint uses rreq->inode, should set it when allocating.
> 
> Fixes: d435d53228dd ("erofs: change to use asynchronous io for fscache
> readpage/readahead")

Should not wrap long 'fixes' line.

> Signed-off-by: Xin Yin <yinxin.x at bytedance.com>

Reviewed-by: Chao Yu <chao at kernel.org>

Thanks,


More information about the Linux-erofs mailing list