[External] Re: [PATCH v2] erofs: change to use asyncronous io for fscache readpage/readahead

[Xin Yin]

On Sat, May 7, 2022 at 9:08 PM JeffleXu <jefflexu at linux.alibaba.com> wrote:
>
>
>
> On 5/7/22 4:31 PM, Xin Yin wrote:
> > Use asyncronous io to read data from fscache may greatly improve IO
> > bandwidth for sequential buffer read scenario.
> >
> > Change erofs_fscache_read_folios to erofs_fscache_read_folios_async,
> > and read data from fscache asyncronously. Make .readpage()/.readahead()
> > to use this new helper.
> >
> > Signed-off-by: Xin Yin <yinxin.x at bytedance.com>
> > ---
>
> s/asyncronous/asynchronous/
> s/asyncronously/asynchronously/
>
Thanks for pointing this out , I will fix it.

> BTW, "convert to asynchronous readahead" may be more concise?
>
You mean the title of this patch?  But, actually we also change to use
this asynchronous io helper for .readpage() now , so I think we need
to point this in the title. right ?

Thanks,
Xin Yin
> Apart from that, LGTM
>
> Reviewed-by: Jeffle Xu <jefflexu at linux.alibaba.com>
>
>
> --
> Thanks,
> Jeffle