mainline build failure due to 6c77676645ad ("iov_iter: Fix iter_xarray_get_pages{,_alloc}()")

Al Viro viro at
Sat Jun 11 22:37:44 AEST 2022

On Sat, Jun 11, 2022 at 12:12:47PM +0000, Al Viro wrote:

> At a guess, should be
> 	return min((size_t)nr * PAGE_SIZE - offset, maxsize);
> in both places.  I'm more than half-asleep right now; could you verify that it
> (as the last lines of both iter_xarray_get_pages() and iter_xarray_get_pages_alloc())
> builds correctly?

No, I'm misreading it - it's unsigned * unsigned long - unsigned vs. size_t.
On arm it ends up with unsigned long vs. unsigned int; functionally it *is*
OK (both have the same range there), but it triggers the tests.  Try 

	return min_t(size_t, nr * PAGE_SIZE - offset, maxsize);

there (both places).

Al, going back to sleep - 4 hours is not enough...

More information about the Linux-erofs mailing list