[PATCH] erofs-utils: add missing errors and normalize errors to lower-case

Gao Xiang hsiangkao at linux.alibaba.com
Sat Jan 29 17:13:18 AEDT 2022

On Sat, Jan 29, 2022 at 01:56:30PM +0800, Gao Xiang wrote:
> On Sat, Jan 29, 2022 at 07:47:31AM +0200, Igor Eisberg wrote:
> > Point regarding conclusive messages taken, will revert the relevant lines.
> Thank.
> > As for the time variable, all I did was to match it to the format as in the
> > case of HAVE_UTIMENSAT, just above it.
> > Although the variable isn't used further, inlining it is unreadable.
> > 
> Please don't. Otherwise, complier will complain
> "mixed declarations and code"
> and I don't want to initialize such structures at the beginning of any
> block.

Add some word. Actually, I'd like to add:
if (!fsckcfg.extract_path)

at the beginning of erofsfsck_set_attributes() instead of
using "if (!ret && fsckcfg.extract_path)" in the caller.

So the HAVE_UTIMENSAT case needs to be resolved as well.

Btw, I have no idea why it could become unreadable to you, first,
it would avoid "mixed declarations and code" unless defining them at the
beginning of blocks, and I don't like memset(.., 0, ) and set
independently since memset generally is a library function (unless
compliers do some built-in tricks) rather than a language feature.

Gao Xiang

> Thanks,
> Gao Xiang

More information about the Linux-erofs mailing list