[PATCH] erofs-utils: fix some style problems

Huang Jianan huangjianan at oppo.com
Wed Feb 23 18:19:59 AEDT 2022


在 2022/2/18 14:20, Gao Xiang 写道:
> Hi Jianan,
>
> On Fri, Feb 18, 2022 at 11:11:37AM +0800, Huang Jianan via Linux-erofs wrote:
>> Fix some minor issues, including:
>>    - Align with the left parenthesis;
>>    - Spelling mistakes;
>>    - Remove redundant spaces and parenthesis;
>>    - clean up file headers;
>>    - Match parameters with format parameters.
>>
>> Signed-off-by: Huang Jianan <huangjianan at oppo.com>
>> ---
>>   dump/main.c                | 53 +++++++++++++++++++-------------------
>>   fsck/main.c                |  4 +--
>>   fuse/main.c                |  1 -
>>   include/erofs/block_list.h |  4 +--
>>   include/erofs/defs.h       |  1 -
>>   include/erofs/dir.h        |  2 +-
>>   include/erofs/internal.h   |  2 +-
>>   include/erofs/list.h       |  1 -
>>   lib/blobchunk.c            |  2 +-
>>   lib/cache.c                |  1 -
>>   lib/compress.c             |  2 +-
>>   lib/compress_hints.c       |  2 +-
>>   lib/compressor_liblzma.c   |  5 ++--
>>   lib/data.c                 |  2 +-
>>   lib/dir.c                  |  2 +-
>>   lib/exclude.c              |  2 +-
>>   lib/inode.c                |  2 +-
>>   lib/io.c                   |  2 +-
>>   lib/liberofs_private.h     |  2 +-
>>   lib/namei.c                |  1 -
>>   lib/super.c                |  4 +--
>>   lib/xattr.c                |  4 +--
>>   mkfs/main.c                |  2 +-
>>   23 files changed, 48 insertions(+), 55 deletions(-)
>>
>> diff --git a/dump/main.c b/dump/main.c
>> index e6198a0..3f8c2f2 100644
>> --- a/dump/main.c
>> +++ b/dump/main.c
>> @@ -179,7 +179,7 @@ static int erofsdump_parse_options_cfg(int argc, char **argv)
>>   }
>>   
>>   static int erofsdump_get_occupied_size(struct erofs_inode *inode,
>> -		erofs_off_t *size)
>> +				       erofs_off_t *size)
> There are two acceptable style (which follows kernel code style),
> 1) the one is aligned with the parentheses in the previous line;
> 2) the other is just using two indentations.
>
> So here we actually don't need to update... btw, was it reported
> by checkpatch.pl?

It was reported by checkpatch.pl with --strict. If these are unnecessary,
I can remove this type of modification from this patch, since there are
some other modifications.

Thanks,
Jianan

> Thanks,
> Gao Xiang



More information about the Linux-erofs mailing list