[PATCH 2/3] erofs_fs.h: Make LFS mandatory for all usecases

Khem Raj raj.khem at gmail.com
Thu Dec 15 16:26:21 AEDT 2022


On Wed, Dec 14, 2022 at 8:12 PM Gao Xiang <hsiangkao at linux.alibaba.com> wrote:
>
> Hi Khem,
>
> On Sat, Dec 10, 2022 at 11:49:25AM -0800, Khem Raj wrote:
>
> ...
>
> > > >
> > > > as said above if we are ok to pass it always then we can add -D
> > > > _FILE_OFFSET_BITS=64 via toplevel Makefile.am
> > > > it will only be needed on 32bit systems though, so maybe we do not
> > > > define it and demand it from users via CFLAGS
> > > > if they compile it for 32bit systems.
> > > >
> > >
> > > I think use -D _FILE_OFFSET_BITS=64 would be a better choice...
> > >
> >
> > OK I will rework it in v3.
>
> Do you still have some interest to work on this?
> (I'm about to release erofs-utils 1.6 in a month.. It would be helpful
>  to clean up such stuff in this version.)

Yes, I am testing a build of v3 today, and I will send out the v3
patchset soon after that.

>
> Thanks,
> Gao Xiang
>
> >
> > > Thanks,
> > > Gao Xiang


More information about the Linux-erofs mailing list