[PATCH v3 0/8] U-boot: fs: add generic unaligned read offset handling
Qu Wenruo
wqu at suse.com
Mon Aug 15 21:45:11 AEST 2022
[CHANGELOG]
v3:
- Fix an error that we always return 0 actread bytes for unsupported fses
For unsupported fses, we should also populate @total_read.
Or we will just read the data but still return 0 for actually bytes.
Now it pass all test_fs* cases.
v2
- Fix a linkage error where (U64 % U32) is called without proper helper
Fix it with U64 & (U32 - 1), as the U32 value (@blocksize) should
always be power of 2, thus (@blocksize - 1) is the mask we want to
calculate the offset inside the block.
Above change only affects the 4th patch, everything else is not
touched.
RFC->v1:
- More (manual) testing
Unfortunately, in the latest master (75967970850a), the fs-tests.sh
always seems to hang at preparing the fs image.
Thus still has to do manual testing, tested btrfs, ext4 and fat, with
aligned and unaligned read, also added soft link read, all looks fine here.
Extra testing is still appreciated.
- Two more btrfs specific bug fixes
All exposed during manual tests
- Remove the tailing unaligned block handling
In fact, all fses can easily handle such case, just a min() call is
enough.
- Remove the support for sandboxfs
Since it's using read() calls, really no need to do block alignment
check.
- Enhanced blocksize check
Ensure the returned blocksize is not only non-error, but also
non-zero.
Qu Wenruo (8):
fs: fat: unexport file_fat_read_at()
fs: btrfs: fix a bug which no data get read if the length is not 0
fs: btrfs: fix a crash if specified range is beyond file size
fs: btrfs: move the unaligned read code to _fs_read() for btrfs
fs: ext4: rely on _fs_read() to handle leading unaligned block read
fs: fat: rely on higher layer to get block aligned read range
fs: ubifs: rely on higher layer to do unaligned read
fs: erofs: add unaligned read range handling
fs/btrfs/btrfs.c | 33 ++++++++---
fs/btrfs/inode.c | 89 +++--------------------------
fs/erofs/internal.h | 1 +
fs/erofs/super.c | 6 ++
fs/ext4/ext4fs.c | 22 +++++++
fs/fat/fat.c | 17 +++++-
fs/fs.c | 130 +++++++++++++++++++++++++++++++++++++++---
fs/ubifs/ubifs.c | 13 +++--
include/btrfs.h | 1 +
include/erofs.h | 1 +
include/ext4fs.h | 1 +
include/fat.h | 3 +-
include/ubifs_uboot.h | 1 +
13 files changed, 212 insertions(+), 106 deletions(-)
--
2.37.1
More information about the Linux-erofs
mailing list