[RFC PATCH 2/3] erofs-utils: fuse: export erofs_xattr_foreach

[Gao Xiang]

On Tue, Aug 09, 2022 at 12:18:34PM +0800, Sheng Yong wrote:
> 
> 
> 在 2022/8/9 11:58, Gao Xiang 写道:
> > Hi Yong,
> > 
> > On Thu, Aug 04, 2022 at 03:46:24AM +0800, Gao Xiang wrote:
> > > 
> > > On Wed, Aug 03, 2022 at 10:22:22PM +0800, Sheng Yong wrote:
> > > > This patch exports erofs_xattr_foreach() to iterate all xattrs.
> > > > Each xattr entry is handled by operations defined in `struct
> > > > xattr_iter_ops'.
> > > > 
> > > 
> > > Thanks for your hard effort!
> > > 
> > > Could we import in-kernel xattr implementation with verify enabled
> > > (or unify these implementations) instead?
> > > 
> > > ( Jianan ported a kernel implementation before, could we enhance
> > >    it with verification?
> > >    https://lore.kernel.org/r/20220728120910.61636-1-jnhuang@linux.alibaba.com)
> > > 
> > 
> > We're about to fix FUSE extended attribute support... Would you mind
> > leaving your opinion about this?
> 
> Hi, Xiang
> 
> Sorry for late. At first glance, I though it would be too heavy to port
> in-kernel code when I tried to add xattr to fuse client. But if we want
> a more unified implementation and Jianan has already done it. I'd like
> to try Jianan's version :-)
> 

Okay, got it.  Also if kernel implementation has more chance to simplify
or clean up, let's do it now.  However, it's definitely better if we share
more code between kernel and erofs-utils in common, so we don't need to
maintain / test two different approaches and that could lead to more bugs
if we enhance them even further in the future...

Thanks,
Gao Xiang

> Thanks,
> Sheng Yong
> 
> > 
> > Thanks,
> > Gao Xiang
> > 
> > > Thanks,
> > > Gao Xiang