[PATCH v8 03/20] cachefiles: notify user daemon with anon_fd when looking up cookie

David Howells dhowells at redhat.com
Mon Apr 11 22:28:57 AEST 2022

Jeffle Xu <jefflexu at linux.alibaba.com> wrote:

> +	  This permits on-demand read mode of cachefiles. In this mode, when
> +	  cache miss, the cachefiles backend instead of netfs, is responsible
> +          for fetching data, e.g. through user daemon.

That third line should probably begin with a tab as the other two line do.

> +static inline void cachefiles_flush_reqs(struct cachefiles_cache *cache)

If it's in a .c file, there's no need to mark it "inline".  The compiler will
inline it anyway if it decides it should.

> +	cachefiles_flush_reqs(cache);
> +	xa_destroy(&cache->reqs);
> +#endif

If cachefiles_flush_reqs() is only used in this one place, the xa_destroy()
should possibly be moved into it.


More information about the Linux-erofs mailing list