[PATCH] erofs: get rid of ->lru usage

Kent Overstreet kent.overstreet at gmail.com
Mon Oct 25 03:59:22 AEDT 2021


On Fri, Oct 22, 2021 at 05:01:20PM +0800, Gao Xiang wrote:
> Currently, ->lru is a way to arrange non-LRU pages and has some
> in-kernel users. In order to minimize noticable issues of page
> reclaim and cache thrashing under high memory presure, limited
> temporary pages were all chained with ->lru and can be reused
> during the request. However, it seems that ->lru could be removed
> when folio is landing.
> 
> Let's use page->private to chain temporary pages for now instead
> and transform EROFS formally after the topic of the folio / file
> page design is finalized.
> 
> Cc: Matthew Wilcox <willy at infradead.org>
> Cc: Kent Overstreet <kent.overstreet at gmail.com>
> Cc: Chao Yu <chao at kernel.org>
> Signed-off-by: Gao Xiang <hsiangkao at linux.alibaba.com>

Would it not be an option to use an array of pointers to pages, instead of a
linked list? Arrays are faster than lists, and page->private is another thing we
prefer not to use if we don't have to.

That said - this is definitely preferable to using page->lru - thank you.

Reviewed-by: Kent Overstreet <kent.overstreet at gmail.com>


More information about the Linux-erofs mailing list