[PATCH 24/29] xfs: use xfs_direct_write_iomap_ops for DAX zeroing
Darrick J. Wong
djwong at kernel.org
Wed Nov 24 10:02:22 AEDT 2021
On Tue, Nov 09, 2021 at 09:33:04AM +0100, Christoph Hellwig wrote:
> While the buffered write iomap ops do work due to the fact that zeroing
> never allocates blocks, the DAX zeroing should use the direct ops just
> like actual DAX I/O.
>
> Signed-off-by: Christoph Hellwig <hch at lst.de>
Heh. I've wanted to fix this for a long time, but I like your
surrounding cleanups better than anything I had time to work on. :)
Reviewed-by: Darrick J. Wong <djwong at kernel.org>
--D
> ---
> fs/xfs/xfs_iomap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/xfs/xfs_iomap.c b/fs/xfs/xfs_iomap.c
> index 8cef3b68cba78..704292c6ce0c7 100644
> --- a/fs/xfs/xfs_iomap.c
> +++ b/fs/xfs/xfs_iomap.c
> @@ -1324,7 +1324,7 @@ xfs_zero_range(
>
> if (IS_DAX(inode))
> return dax_zero_range(inode, pos, len, did_zero,
> - &xfs_buffered_write_iomap_ops);
> + &xfs_direct_write_iomap_ops);
> return iomap_zero_range(inode, pos, len, did_zero,
> &xfs_buffered_write_iomap_ops);
> }
> @@ -1339,7 +1339,7 @@ xfs_truncate_page(
>
> if (IS_DAX(inode))
> return dax_truncate_page(inode, pos, did_zero,
> - &xfs_buffered_write_iomap_ops);
> + &xfs_direct_write_iomap_ops);
> return iomap_truncate_page(inode, pos, did_zero,
> &xfs_buffered_write_iomap_ops);
> }
> --
> 2.30.2
>
More information about the Linux-erofs
mailing list