[PATCH v1 1/4] Make erofs_devfd a parameter for most functions

[Gao Xiang]

Hi Kelvin,

On Sat, Nov 20, 2021 at 09:39:18PM -0800, Kelvin Zhang wrote:
> Test: extract system.img from
> aosp_cf_x86_64_phone-target_files-7731383.zip , mount it, mkfs.erofs to
> generate an EROFS image. Make sure the content is the same before/after
> this patch. (Except super block, which has an UUID)
> 
> target_files.zip can be downloaded from
> https://ci.android.com/builds/branches/aosp-master/grid?head=7934850&tail=7934850
> 
> Signed-off-by: Kelvin Zhang <zhangkelvin at google.com>

Thanks for your effort!

Just a quick glance, I'm not sure if we have to expose erofs_device to
most of the functions... Also it breaks some common functions argument
lists which was porting from the kernel side.

How about integrating struct erofs_device to struct erofs_sb_info? and
make inode->sb_info->dev chain workable?

Also it would be better to leave a descriptive commit message ;) it
would be helpful!

Thanks,
Gao Xiang

> ---
>  dump/main.c               | 61 +++++++++++++++--------------
>  fsck/main.c               | 65 ++++++++++++++++---------------
>  fuse/dir.c                |  7 +++-
>  fuse/main.c               | 18 +++++----
>  include/erofs/blobchunk.h |  7 +++-
>  include/erofs/cache.h     |  7 ++--
>  include/erofs/compress.h  |  8 +++-
>  include/erofs/config.h    | 15 ++++----
>  include/erofs/defs.h      | 21 ++++++++++
>  include/erofs/inode.h     |  6 ++-
>  include/erofs/internal.h  | 52 +++++++++----------------
>  include/erofs/io.h        | 48 ++++++++++++++---------
>  lib/blobchunk.c           | 11 ++++--
>  lib/cache.c               | 27 ++++++++-----
>  lib/compress.c            | 54 ++++++++++++++------------
>  lib/compressor_liblzma.c  |  2 +-
>  lib/config.c              | 63 ++++++++++++++++++------------
>  lib/data.c                | 30 +++++++++------
>  lib/decompress.c          |  2 +-
>  lib/inode.c               | 81 +++++++++++++++++++++++----------------
>  lib/io.c                  | 74 +++++++++++++++++++----------------
>  lib/namei.c               | 22 +++++------
>  lib/super.c               | 28 +++++++-------
>  lib/xattr.c               |  6 ++-
>  lib/zmap.c                | 74 +++++++++++++++++++++--------------
>  mkfs/main.c               | 39 ++++++++++---------
>  26 files changed, 476 insertions(+), 352 deletions(-)
>