[PATCH v6] iomap: support tail packing inline read
Gao Xiang
hsiangkao at linux.alibaba.com
Sat Jul 24 01:23:38 AEST 2021
Hi Matthew,
On Fri, Jul 23, 2021 at 04:05:29PM +0100, Matthew Wilcox wrote:
> On Thu, Jul 22, 2021 at 07:39:47AM +0200, Christoph Hellwig wrote:
> > @@ -675,7 +676,7 @@ static size_t iomap_write_end_inline(struct inode *inode, struct page *page,
> >
> > flush_dcache_page(page);
> > addr = kmap_atomic(page);
> > - memcpy(iomap->inline_data + pos, addr + pos, copied);
> > + memcpy(iomap_inline_buf(iomap, pos), addr + pos, copied);
>
> This is wrong; pos can be > PAGE_SIZE, so this needs to be
> addr + offset_in_page(pos).
Yeah, thanks for pointing out. It seems so, since EROFS cannot test
such write path, previously it was disabled explicitly. I could
update it in the next version as above.
Thanks,
Gao Xiang
More information about the Linux-erofs
mailing list