[PATCH v3 2/2] Add API to iterate over inodes in EROFS

[Gao Xiang]

On Mon, Dec 13, 2021 at 06:59:28PM -0800, Kelvin Zhang wrote:
> I think we still need parent_nid to skip "." and ".." directories
> correctly? Let's leave these parameters there.

We could also just skip these by the name ("." and "..") instead
of nids. parent nid is just for sanity check.

Thanks,
Gao Xiang

> 
> On Mon, Dec 13, 2021 at 6:50 PM Gao Xiang <hsiangkao at linux.alibaba.com>
> wrote:
> 
> > On Mon, Dec 13, 2021 at 06:25:09PM -0800, Kelvin Zhang wrote:
> > > Fixed most of the issues you pointed out. Except I didn't quite
> > understand
> > > the "nid is optional unless we do a fsck." part. Not sure how we can
> > > implement the iterate dir function w/o nid. Can you provide more context?
> >
> > There were two nids there, parent_nid and nid. I meant you could leave
> > dir nid (no matter how it's called) mandatorily. dir's parent nid is
> > optional.
> >
> > Sorry if I made some confusion at that time.
> >
> > Thanks,
> > Gao Xiang
> >
> 
> 
> -- 
> Sincerely,
> 
> Kelvin Zhang