[PATCH -next] erofs: make symbol 'erofs_iomap_ops' static

Chao Yu chao at kernel.org
Mon Aug 9 09:56:44 AEST 2021


On 2021/8/8 21:19, Gao Xiang wrote:
> On Sun, Aug 08, 2021 at 06:33:43AM +0000, Wei Yongjun wrote:
>> The sparse tool complains as follows:
>>
>> fs/erofs/data.c:150:24: warning:
>>   symbol 'erofs_iomap_ops' was not declared. Should it be static?
>>
>> This symbol is not used outside of data.c, so marks it static.

Thanks for the patch, I guess it will be better to fix in original patch
if you don't mind.

Thanks,

>>
>> Fixes: 3e9ce908c114 ("erofs: iomap support for non-tailpacking DIO")
>> Reported-by: Hulk Robot <hulkci at huawei.com>
>> Signed-off-by: Wei Yongjun <weiyongjun1 at huawei.com>
> 
> Thanks,
> Reviewed-by: Gao Xiang <hsiangkao at linux.alibaba.com>
> 
> Thanks,
> Gao Xiang
> 


More information about the Linux-erofs mailing list