[PATCH][next] erofs: fix uninitialized variable i used in a while-loop
Colin King
colin.king at canonical.com
Wed Apr 7 02:27:18 AEST 2021
From: Colin Ian King <colin.king at canonical.com>
The while-loop iterates until src is non-null or i is 3, however, the
loop counter i is not intinitialied to zero, causing incorrect iteration
counts. Fix this by initializing it to zero.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 1aa5f2e2feed ("erofs: support decompress big pcluster for lz4 backend")
Signed-off-by: Colin Ian King <colin.king at canonical.com>
---
fs/erofs/decompressor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/erofs/decompressor.c b/fs/erofs/decompressor.c
index fe46a9c34923..8687ff81406b 100644
--- a/fs/erofs/decompressor.c
+++ b/fs/erofs/decompressor.c
@@ -154,6 +154,7 @@ static void *z_erofs_handle_inplace_io(struct z_erofs_decompress_req *rq,
}
kunmap_atomic(inpage);
might_sleep();
+ i = 0;
while (1) {
src = vm_map_ram(rq->in, nrpages_in, -1);
/* retry two more times (totally 3 times) */
--
2.30.2
More information about the Linux-erofs
mailing list