[PATCH] erofs: remove unneeded parameter

Gao Xiang hsiangkao at redhat.com
Thu Sep 17 00:36:48 AEST 2020


On Wed, Sep 16, 2020 at 10:33:04PM +0800, Gao Xiang wrote:
> Hi Chao,
> 
> On Wed, Sep 16, 2020 at 10:06:04PM +0800, Chao Yu wrote:
> > From: Chao Yu <yuchao0 at huawei.com>
> > 
> > In below call path, no page will be cached into @pagepool list
> > or grabbed from @pagepool list:
> > - z_erofs_readpage
> >  - z_erofs_do_read_page
> >   - preload_compressed_pages
> >   - erofs_allocpage
> > 
> > Let's get rid of this unneeded parameter.
> 
> That would be unneeded after .readahead() is introduced recently
> (so add_to_page_cache_lru() is also moved to mm code), so I agree
> with you on it.

(cont.)

... also it'd be better to add such historical reason to the commit
message... since it was of some use before...

Thanks,
Gao Xiang



More information about the Linux-erofs mailing list