[PATCH 0/3] erofs: remove tags of pointers stored in a radix tree

Gao Xiang gaoxiang25 at huawei.com
Thu Jan 2 23:55:51 AEDT 2020


Hi Vladimir,

On Thu, Jan 02, 2020 at 02:01:15PM +0200, Vladimir Zapolskiy wrote:
> The changeset simplifies a couple of internal interfaces and removes
> excessive tagging and untagging of workgroup pointers stored in a radix
> tree.
> 
> All the changes in the series are non-functional.

This radix tree tag was planned to be reserved for other use in order
to differ it from the current fixed-sized output compression management
structure. I agree that it can be simplified for now, so I will test
this series and apply. However, I think such XArray tagged pointer
usage is useful.

p.s. I'm converting this radix tree to XArray and cleaning up
related functions for the next cycle as well.

Thanks,
Gao Xiang

> 
> Vladimir Zapolskiy (3):
>   erofs: remove unused tag argument while finding a workgroup
>   erofs: remove unused tag argument while registering a workgroup
>   erofs: remove void tagging/untagging of workgroup pointers
> 
>  fs/erofs/internal.h |  4 ++--
>  fs/erofs/utils.c    | 15 ++++-----------
>  fs/erofs/zdata.c    |  5 ++---
>  3 files changed, 8 insertions(+), 16 deletions(-)
> 
> -- 
> 2.20.1
> 


More information about the Linux-erofs mailing list