[PATCH v2] erofs: fix wrong address in erofs_get_block

Gao Xiang hsiangkao at redhat.com
Tue Dec 8 21:35:35 AEDT 2020


On Tue, Dec 08, 2020 at 05:48:10PM +0800, Chao Yu wrote:
> On 2020/12/8 17:31, Huang Jianan wrote:
> > iblock indicates the number of i_blkbits-sized blocks rather than
> > sectors, fix it.
> > 
> > If the data has a disk mapping, map_bh should be used to read the
> > correct data from the device.
> 
> Thanks for the fix, I was misled by sector_t type...
> 
> What about avoiding using generic_block_bmap() which uses buffer_head
> structure, it limits mapped size to 32-bits:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git/commit/?h=dev-test&id=b876f4c94c3d1688edea021d45a528571499e0b9

Also a minor thing is to Cc: LKML <linux-kernel at vger.kernel.org>
in the next version and for all kernel patches, which is needed
for upstreaming.

(quite closing to merging window...)

Thanks,
Gao Xiang

> 
> Thanks,



More information about the Linux-erofs mailing list