[PATCH 00/21] erofs: patchset addressing Christoph's comments
Gao Xiang
hsiangkao at aol.com
Wed Sep 4 01:43:46 AEST 2019
Hi Christoph,
On Tue, Sep 03, 2019 at 08:37:04AM -0700, Christoph Hellwig wrote:
> On Tue, Sep 03, 2019 at 04:17:49PM +0800, Gao Xiang wrote:
> > I implement a prelimitary version, but I have no idea it is a really
> > cleanup for now.
>
> The fact that this has to guess the block device address_space
> implementation is indeed pretty ugly. I'd much prefer to just use
> read_cache_page_gfp, and live with the fact that this allocates
> bufferheads behind you for now. I'll try to speed up my attempts to
> get rid of the buffer heads on the block device mapping instead.
Fully agree with your point. Let me use read_cache_page_gfp
instead for now, hoping block device quickly avoiding from
buffer_heads...
Thanks,
Gao Xiang
More information about the Linux-erofs
mailing list