[PATCH] staging: erofs: fix parenthesis alignment

Julian Merida julianmr97 at gmail.com
Wed Mar 20 04:19:37 AEDT 2019


Yes that was my mistake, I'm really sorry!! This was my first contribution
to the kernel and I didn't know who to send the email despite the
maintainers. Also, I thought I shouldn't bother more than necessary.

Gao then told me I should send the patch to you and to the staging mail
list.

Regards,
Julián Mérida

On Tue, Mar 19, 2019, 10:35 Gao Xiang <gaoxiang25 at huawei.com> wrote:

> Hi Greg,
>
> On 2019/3/19 21:28, Greg KH wrote:
> > On Mon, Mar 18, 2019 at 08:58:41PM -0300, Julian Merida wrote:
> >> Fix all checkpatch issues: "CHECK: Alignment should match open
> parenthesis"
> >>
> >> Signed-off-by: Julian Merida <julianmr97 at gmail.com>
> >> Reviewed-by: Gao Xiang <gaoxiang25 at huawei.com>
> >
> > Was this really reviewed by Gao?  Offline or on-list?  I missed it if it
> > was on-list :(
>
> Yes, I was reviewed on the first version...
>
> He didn't cc you and staging mailing list...
> https://lists.ozlabs.org/pipermail/linux-erofs/2019-March/001486.html
>
> It seems no logic change and doing a lot of fixes...
>
> Thanks,
> Gao Xiang
>
> >
> > thanks,
> >
> > greg k-h
> >
>

On Tue, Mar 19, 2019, 10:35 Gao Xiang <gaoxiang25 at huawei.com> wrote:

> Hi Greg,
>
> On 2019/3/19 21:28, Greg KH wrote:
> > On Mon, Mar 18, 2019 at 08:58:41PM -0300, Julian Merida wrote:
> >> Fix all checkpatch issues: "CHECK: Alignment should match open
> parenthesis"
> >>
> >> Signed-off-by: Julian Merida <julianmr97 at gmail.com>
> >> Reviewed-by: Gao Xiang <gaoxiang25 at huawei.com>
> >
> > Was this really reviewed by Gao?  Offline or on-list?  I missed it if it
> > was on-list :(
>
> Yes, I was reviewed on the first version...
>
> He didn't cc you and staging mailing list...
> https://lists.ozlabs.org/pipermail/linux-erofs/2019-March/001486.html
>
> It seems no logic change and doing a lot of fixes...
>
> Thanks,
> Gao Xiang
>
> >
> > thanks,
> >
> > greg k-h
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/linux-erofs/attachments/20190319/e32f880b/attachment.htm>


More information about the Linux-erofs mailing list