[PATCH] staging: erofs: return the error value if fill_inline_data() fails

Greg KH gregkh at linuxfoundation.org
Wed Jun 26 11:43:43 AEST 2019


On Tue, Jun 25, 2019 at 05:29:12PM +0800, Yue Hu wrote:
> On Tue, 25 Jun 2019 17:19:36 +0800
> Gao Xiang <hsiangkao at aol.com> wrote:
> 
> > On 2019/6/25 ????3:59, Yue Hu Wrote:
> > > From: Yue Hu <huyue2 at yulong.com>
> > > 
> > > We should consider the error returned by fill_inline_data() when filling
> > > last page in fill_inode(). If not getting inode will be successful even
> > > though last page is bad. That is illogical. Also change -EAGAIN to 0 in
> > > fill_inline_data() to stand for successful filling.
> > > 
> > > Signed-off-by: Yue Hu <huyue2 at yulong.com>  
> > 
> > looks good to me, yet I think you need to Cc staging mailing list at
> > least if you want to upstream quickly (including your older patches...)
> > 
> > 
> > Reviewed-by: Gao Xiang <gaoxiang25 at huawei.com>
> > 
> > 
> > (Don't forget to add 'PATCH RESEND' tag at the subject line if you
> > resend these patches.)
> 
> Ok, got it.

Yes, please resend all of these patches as I am not quite sure which
ones are the "latest".

thanks,

greg k-h


More information about the Linux-erofs mailing list