[PATCH 07/22] staging: erofs: remove redundant #include "internal.h"
Gao Xiang
gaoxiang25 at huawei.com
Wed Jul 31 17:08:50 AEST 2019
Hi Chao,
On 2019/7/31 15:03, Chao Yu wrote:
> On 2019/7/29 14:51, Gao Xiang wrote:
>> Because #include "internal.h" is included in xattr.h
>
> I think it would be better to remove "internal.h" in xattr.h, and include them
> both in .c file in where we need xattr definition.
It seems that all xattr related source files needing internal.h,
and we need "EROFS_V(inode)", "struct erofs_sb_info", ... stuffs in xattr.h,
which is defined in internal.h...
Thanks,
Gao Xiang
>
> Thanks,
>
More information about the Linux-erofs
mailing list