[PATCH 0/2] staging: erofs: fixed -Wmissing-prototype warnings.

Gao Xiang gaoxiang25 at huawei.com
Tue Jan 8 12:46:18 AEDT 2019


Hi Jeremy,

On 2019/1/8 2:25, Jeremy Sowden wrote:
> Fixes for -Wmissing-prototype warnings in the erofs driver.  One group of
> functions have been made static; for the second, prototypes have been moved to a
> head

Is -Wmissing-prototypes required for the current linux kernel?
I cannot see this warning in my personal kernel compilation...

Functions your fix have already been added proper erofs prefix,
therefore it wouldn't pollute the global namespace:
z_erofs_vle_work_release
z_erofs_unzip_lz4
erofs_try_to_release_workgroup

erofs_workgroup_free_rcu
z_erofs_map_blocks_iter

some thought?

Thanks,
Gao Xiang


More information about the Linux-erofs mailing list