[PATCH for-4.19 00/12] erofs fixes for linux-4.19.y

[Gao Xiang]

Hi Greg,

On 2019/2/22 16:35, Greg Kroah-Hartman wrote:
> On Wed, Feb 20, 2019 at 05:18:42PM +0800, Gao Xiang wrote:
>> This series backports bugfixes already merged in linux upstream
>> which we found these issues in our commerical products, which
>> are serious and should be fixed immediately.
>>
>> Note that it also includes some xarray modification since
>> upcoming patches heavily needs it, which can reduce more
>> conflicts later.
>>
>> All patches have been tested again as a whole.
> 
> Some of these patches are not in 4.20, so if a user were to move to that
> kernel, they would see a "regression" in the filesystem functionality,
> right?  That's not ok, and because of that reason alone, I can't take
> this whole series for 4.19.y right now.

Yes, you are right. I think 4.20 should be fixed as well.
I will do it later for 4.20 and the reason I did 4.19 first is just because
it is a LTS kernel...

> 
> So can you prepare a set of patches for 4.20.y also with the missing
> patches you have included here?

I will do that.

> 
> Also, are all of these really "fixes"?  They feel like they are basic
> "get things working properly" type of patches.  The BUG_ONs are not
> really fixes as no one _should_ be hitting those in a normal system,
> right?  Are they really necessary for systems running 4.19?

Most of these BUG_ONs will crash kernel when mounted with corrupted images,
since I plan to take time to run EROFS linux 4.19 LTS in AOSP, those patches
are important to do that...

Thanks,
Gao Xiang

> 
> thanks,
> 
> greg k-h
>