[PATCH v6 01/24] erofs: add on-disk layout
Gao Xiang
gaoxiang25 at huawei.com
Thu Aug 29 20:58:11 AEST 2019
Hi Christoph,
On Thu, Aug 29, 2019 at 03:36:04AM -0700, Christoph Hellwig wrote:
> On Thu, Aug 29, 2019 at 06:32:53PM +0800, Gao Xiang wrote:
> > I can fix it up as you like but I still cannot get
> > what is critical issues here.
>
> The problem is that the whole codebase is way substandard quality,
> looking a lot like Linux code from 20 years ago. Yes, we already have
> plenty of code of that standard in the tree, but we should not add more.
I still cannot get your point what does your substandard quality mean,
please refer to some thing critical in EROFS (and I noticed that your
new code still has bug) rather than naming.
Thanks,
Gao Xiang
More information about the Linux-erofs
mailing list