[PATCH v6 08/24] erofs: add namei functions

Christoph Hellwig hch at infradead.org
Thu Aug 29 20:28:38 AEST 2019


On Fri, Aug 02, 2019 at 08:53:31PM +0800, Gao Xiang wrote:
> +struct erofs_qstr {
> +	const unsigned char *name;
> +	const unsigned char *end;
> +};

Maybe erofs_name?  The q in qstr stands for quick, because of the
existing hash and len, which this doesn't really provide.

Also I don't really see why you don't just pass the actual qstr and
just document that dirnamecmp does not look at the hash and thus
doesn't require it to be filled out.



More information about the Linux-erofs mailing list