[PATCH v3] staging: erofs: use explicit unsigned int type

Thomas Weißschuh linux at weissschuh.net
Tue Sep 11 05:15:28 AEST 2018


Hi Greg,

On Mon, 2018-09-10T10:10+0200, Greg Kroah-Hartman wrote:
> On Sun, Sep 09, 2018 at 08:37:53PM +0200, Thomas Weißschuh wrote:
> > Changes since v1:
> > 
> > * Removed changes that conflicted with
> >   [PATCH 1/6] staging: erofs: formatting fix in unzip_vle_lz4.c
> > * Added patch description
> > 
> > Changes since v2:
> > 
> > * Fixed conflicts with other patchsets
> > * Don't introduce new style issues
> > 
> 
> These changes belong below the --- line, not above it.  I'm not sure if
> git will handle this line:

> 
> > -- >8 --

The patch was supposed to be applied with "git am --scissors".
To be honest, I am not sure if the scissors feature of git is to be used for
kernel development, or if I should have announced it.
If is not applicable I will be happy to resend the patch in another format.

The documentation for git-mailinfo(1) sounded it would fit my usecase perfectly:

   ...
   This is useful if you want to begin your message in a discussion thread with comments and suggestions on the message you are responding to, and to conclude it with a
   patch submission, separating the discussion and the beginning of the proposed commit log message with a scissors line.
   ...

> Correctly or not, have you tried it?

I tried to both apply and compile the patch, both succeeded.

Thomas


More information about the Linux-erofs mailing list