[PATCH 08/10] staging: erofs: locked before registering for all new workgroups
Gao Xiang
gaoxiang25 at huawei.com
Thu Nov 22 21:35:00 AEDT 2018
Hi Greg,
On 2018/11/22 18:24, Greg Kroah-Hartman wrote:
>> + /* lock all primary followed works before visible to others */
>> + if (unlikely(!mutex_trylock(&work->lock)))
>> + /* for a new workgroup, try_lock *never* fails */
>> + DBG_BUGON(1);
> Again, drop this, if it never fails, then there's no need for this. If
> it can fail, then properly handle it.
>
> And trylock can fail, so this needs to be fixed.
OK, I will drop this.
Thanks,
Gao Xiang
>
> thanks,
More information about the Linux-erofs
mailing list