[PATCH chao/erofs-dev rebased v2 10/12] staging: erofs: separate into init_once / always

[Gao Xiang]

Hi Chao,

On 2018/11/20 15:00, Chao Yu wrote:
> On 2018/11/14 23:29, Gao Xiang wrote:
>> `z_erofs_vle_workgroup' is heavily generated in the decompression,
>> for example, it resets 32 bytes redundantly for 64-bit platforms
>> even through Z_EROFS_VLE_INLINE_PAGEVECS + Z_EROFS_CLUSTER_MAX_PAGES,
>> default 4, pages are stored in `z_erofs_vle_workgroup'.
>>
>> As an another example, `struct mutex' takes 72 bytes for our kirin
>> 64-bit platforms, it's unnecessary to be reseted at first and
>> be initialized each time.
>>
>> Let's avoid filling all `z_erofs_vle_workgroup' with 0 at first
>> since most fields are reinitialized to meaningful values later,
>> and pagevec is no need to initialized at all.
>>
>> Signed-off-by: Gao Xiang <gaoxiang25 at huawei.com>
> In [09/12], it says:
> 
> drivers/staging/erofs/unzip_vle.c: In function ‘init_always
> 
> But actually, we introduce it in [10/12].
> 
> So this patch should be relocated to [09/12]?

[09/12] staging: erofs: fix the definition of DBG_BUGON was introduced to
fix [10/12] staging: erofs: separate into init_once / always uninitialized warning...

But actually it is a generic issue if EROFS_FS_DEBUG is off, [10/12] was taken
as an example...

Thanks,
Gao Xiang

> 
> Reviewed-by: Chao Yu <yuchao0 at huawei.com>
> 
> Thanks,
>