[PATCH chao/erofs-dev rebased v2 05/12] staging: erofs: fix race when the managed cache is enabled

Gao Xiang gaoxiang25 at huawei.com
Tue Nov 20 14:44:52 AEDT 2018


Hi Chao,

On 2018/11/20 11:24, Chao Yu wrote:
>> +		/*
>> +		 * it's safe to decrease since the workgroup isn't visible
>> +		 * and refcount >= 2 (cannot be freezed).
>> +		 */
>> +		atomic_dec(&grp->refcount);
> How about:
> 
> #define __erofs_workgroup_put(grp)	atomic_dec(&grp->refcount);
> 
> Otherwise, it looks good to me.
> 

OK, I will fix it soon and send the whole next version patchset
including this modification.

Thanks,
Gao Xiang

> Reviewed-by: Chao Yu <yuchao0 at huawei.com>
> 
> Thanks,
> 


More information about the Linux-erofs mailing list