[Outreachy kernel] Re: [PATCH v3 2/2] staging: erofs: Modify conditional checks

[Gao Xiang]

Hi Bhagyashri,

On 2018/11/6 2:07, Bhagyashri Dighole wrote:
> Hi Gao,
> 
> In PATCH version v1 which is first stage of contribution, I modified data.c for all alignment changes and all conditional checks. As per discussion on email for this patch, It was concluded that I need to re-submit patch for single change at a time.
> 
> So, I created PATCH v2. In this patch, I modified data.c only for single conditional check and single alignment change and committed accordingly. As per Gao’s suggestion to do all alignment change in a first patch and all conditional changes in another patch, I modified and created PATCH v3.
> 
> PATCH v3 is divided into two patches.
> 1) PATCH v3 1/2 has all alignment changes.
> 2) PATCH v3 2/2 has all conditional changes.

That is correct. However, you send two patchset of v3, see:

v3. the first time
1) https://lists.ozlabs.org/pipermail/linux-erofs/2018-November/000796.html
2) https://lists.ozlabs.org/pipermail/linux-erofs/2018-November/000797.html
2.1) https://lists.ozlabs.org/pipermail/linux-erofs/2018-November/000798.html
v3. the second time
1) https://lists.ozlabs.org/pipermail/linux-erofs/2018-November/000800.html
2) https://lists.ozlabs.org/pipermail/linux-erofs/2018-November/000801.html

It is hard for me to know which one is the latest version of your patchset.
If you send a newer version, you should use v4 instead of v3 (even if you
decide to add a changelog), or

If you resend the patchset (same as the previous one, just to remind us to review),
  you should use [PATCH v3 RESEND] for this case.

> 
> Also, I mentioned what changes each version of patch represents under ‘—-‘ symbol.

Yes, but I think you should use v4 rather than v3 to add a changelog as Greg mentioned.

> 
> I am not able to understand, where I am making mistake? Can you please help me?

That is my personal suggestion, maybe of some help for you...

Thanks,
Gao Xiang