[Outreachy kernel] Re: [PATCH v2 1/2] staging: erofs: Modify conditional check.

Gao Xiang gaoxiang25 at huawei.com
Mon Nov 5 16:54:15 AEDT 2018


Hi Bhagyashri,

On 2018/11/5 13:44, Bhagyashri Dighole wrote:
> Thanks Gao. As per discussion in previous mails, I thought we need to submit one change at a time in a patch that's why I modified accordingly. As you suggested it makes sense to fix all similar issues at once and create a single patch for those issues. I will update patch accordingly.
>

hmmm...I think you could make one similar kind of change at once...
For example you can fix all "fix pointer comparisons to NULL" in one patch and fix some else in another patch...

It seems no reason to just fix such one place with a independent patch, right?
Just my personal thought and understanding, you could ignore me if I am wrong. :)

Thanks,
Gao Xiang

>  Thanks 


More information about the Linux-erofs mailing list