[PATCH chao/erofs-dev 4/7] staging: erofs: revisit page submission flow

Chao Yu chao at kernel.org
Fri Dec 7 02:31:27 AEDT 2018


On 2018-12-2 2:32, Gao Xiang wrote:
> Previously, the submission flow works with cached compressed pages
> reclaim path in a tricky way, and it could be buggy if the reclaim
> path changes later without such tricky restrictions. For example,
> currently one PagePrivate(page) is evaluated without taking page
> lock (it only follows a wait_for_page_locked which closes such race)
> and no handling solves the potential page truncation case.
> 
> In addition, it's also full of #ifdefs in the function, which
> is hard to understand and maintain. this patch fixes them all.
> 
> Signed-off-by: Gao Xiang <gaoxiang25 at huawei.com>

Reviewed-by: Chao Yu <yuchao0 at huawei.com>

Thanks,


More information about the Linux-erofs mailing list