[PATCH 3/8] staging: erofs: add error handling for xattr submodule

Chao Yu chao at kernel.org
Mon Aug 13 22:46:44 AEST 2018


On 2018/8/13 20:17, Gao Xiang wrote:
>> Generally the rule on likely/unlikely is that they hurt readability so
>> we should only add them if it makes a difference in benchmarking.
>>
> 
> In my opinion, return values other than 0 and ENOATTR(ENODATA) rarely happens,
> it should be in the slow path...

Hi Dan, thanks for the comments.

IMO, we should check and clean up all likely/unlikely in erofs, to make sure
they are used in the right place.

Thanks,


More information about the Linux-erofs mailing list