[PATCH v5 3/8] ARM: dts: aspeed: yosemite5: Add new SGPIO line names and rename signal
Andrew Jeffery
andrew at codeconstruct.com.au
Wed Mar 4 13:40:59 AEDT 2026
On Mon, 2026-02-23 at 19:17 +0800, Kevin Tung wrote:
> Add new SGPIO line names for user space monitoring and event logging.
>
> Also rename PADDLE_BD_IOEXP_INT to ALERT_IRQ_PMBUS_PWR2_N to match
> hardware naming. The original PADDLE_BD_IOEXP_INT is unused, so this
> change does not affect current system functionality.
Why are these two problems being solved in the one patch?
https://docs.kernel.org/process/submitting-patches.html#split-changes
Essentially, your use of "Also" is a bit of a red flag here.
However, on the specifics, why was the PADDLE_BD_IOEXP_INT hardware
naming wrong to begin with? What changed?
Broadly, it feels a lot like you're revising platform designs, then
trying to make the one devicetree fit the current design, and are not
explicitly communicating that this is what you're doing.
If that _is_ what you're doing, then we can come up with much better
schemes to handle it that aren't a constant stream of compatibility
breaks.
I need you to engage with this concern.
More information about the Linux-aspeed
mailing list