[PATCH v2 1/2] dt-bindings: clock: ast2600: Add reset definition for video

[Haiyue Wang]

On 2/28/2026 8:16 PM, Conor Dooley wrote:
> On Sat, Feb 28, 2026 at 09:20:56AM +0800, Haiyue Wang wrote:
>>
>>
>> On 2/28/2026 1:33 AM, Conor Dooley wrote:
>>> On Fri, Feb 27, 2026 at 11:13:14PM +0800, Haiyue Wang wrote:
>>>> Add ASPEED_RESET_VIDEO reset definition to the ast2600-clock binding
>>>> header. It is required for proper reset control of the video on the
>>>> AST2600 SoC for aspeed-video driver.
>>>>
>>>> Fixes: e83f8dd668ea ("media: aspeed: Fix dram hang at res-change")
>>>
>>> How can a binding change be a fix for a driver one?
>>>
>>
>> https://git.kernel.org/torvalds/c/9897831de614
>>
>> If squashed into one patch as v1 does, it will have patch format warning:
>> ./scripts/checkpatch.pl ...patch
>> WARNING: DT binding docs and includes should be a separate patch. See:
>> Documentation/devicetree/bindings/submitting-patches.rst
> 
> Adding a fixes tag implies that the change you have here should have
> been done in the patch you're citing. If you had done it in that patch,
> you would get a checkpatch warning there too. This is a separate change
> that is needed for your dts changes, but is not a fix for the driver
> change.
> 

 From this point of view, yes, a little strange to add "Fixes".

Drop this tag in V3, please review.

>>
>>>> Signed-off-by: Haiyue Wang <haiyuewa at 163.com>
>>>> ---
>>>> v2:
>>>>     - Fix checkpatch.pl warning, and send dt-bindings as single patch as
>>>>       the submitting-patches guide.
>>>> v1: https://lore.kernel.org/all/20260227123837.70079-1-haiyuewa@163.com/
>>>> ---
>>>>    include/dt-bindings/clock/ast2600-clock.h | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/include/dt-bindings/clock/ast2600-clock.h b/include/dt-bindings/clock/ast2600-clock.h
>>>> index f60fff261130..7b9b80c38a8b 100644
>>>> --- a/include/dt-bindings/clock/ast2600-clock.h
>>>> +++ b/include/dt-bindings/clock/ast2600-clock.h
>>>> @@ -124,6 +124,7 @@
>>>>    #define ASPEED_RESET_PCIE_RC_OEN	18
>>>>    #define ASPEED_RESET_MAC2		12
>>>>    #define ASPEED_RESET_MAC1		11
>>>> +#define ASPEED_RESET_VIDEO		6
>>>>    #define ASPEED_RESET_PCI_DP		5
>>>>    #define ASPEED_RESET_HACE		4
>>>>    #define ASPEED_RESET_AHB		1
>>>> -- 
>>>> 2.53.0
>>>>
>>