[PATCH v18 1/3] dt-bindings: i2c: aspeed,i2c.yaml: add transfer-mode and global-regs properties and update example
Ryan Chen
ryan_chen at aspeedtech.com
Fri Sep 12 19:27:51 AEST 2025
> Subject: Re: [PATCH v18 1/3] dt-bindings: i2c: aspeed,i2c.yaml: add
> transfer-mode and global-regs properties and update example
>
> Hi Ryan,
>
> > And AST2600 i2c controller have two register mode, one is legacy
> > register layout which is mix controller/target register control
> > together, another is new mode which is separate controller/target
> > register control.
>
> OK, but the ast2400 and ast2500 I2C peripherals - which this binding also
> describes - do not have that facility. Given the 2600 is a distinct peripheral (as
> discussed on the v16 series), this would seem to warrant a distinct binding.
>
> Should this be split out into an ast2600-specific binding, to reflect that it is
> different hardware? The reference to the global registers and transfer modes
> would then be added only to the ast2600-i2c-bus binding.
I agree it would be cleaner to split out a new binding file specifically for AST2600,
for example: `aspeed,ast2600-i2c.yaml`
But also I think `aspeed,i2cv2.yaml` more better name, that compatible will
support next generation such like AST2700 .....
If this is ok, I'll proceed to refactor the bindings accordingly in the next version.
Ryan
>
> Cheers,
>
>
> Jeremy
More information about the Linux-aspeed
mailing list