[PATCH v3 1/4] ARM: dts: aspeed: santabarbara: add sensor support for extension boards

[Andrew Jeffery]

Hi Fred,

On Mon, 2025-09-08 at 16:02 +0800, Fred Chen wrote:
> add power monitor and temperature sensors for extension boards in bus 6,
> 8, 10 and 13.
> 
> Signed-off-by: Fred Chen <fredchen.openbmc at gmail.com>
> ---
>  .../aspeed-bmc-facebook-santabarbara.dts      | 824 ++++++++++++++++++
>  1 file changed, 824 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-santabarbara.dts
> index ee93a971c500..2f5712e9ba9f 100644

*snip*

> @@ -574,6 +606,204 @@ eeprom at 52 {
>                 compatible = "atmel,24c256";
>                 reg = <0x52>;
>         };
> +
> +       i2c-mux at 71 {
> +               compatible = "nxp,pca9546";
> +               reg = <0x71>;
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +               i2c-mux-idle-disconnect;
> +
> +               i2c6mux0ch0: i2c at 0 {
> +                       reg = <0>;
> +                       #address-cells = <1>;
> +                       #size-cells = <0>;
> +
> +                       temperature-sensor at 64 {
> +                               compatible = "microchip,mcp9600";
> +                               reg = <0x64>;
> +                       };
> +
> +                       temperature-sensor at 65 {
> +                               compatible = "microchip,mcp9600";
> +                               reg = <0x65>;
> +                       };
> +
> +                       temperature-sensor at 67 {
> +                               compatible = "microchip,mcp9600";
> +                               reg = <0x67>;
> +                       };
> +
> +                       i2c-mux at 72 {
> +                               compatible = "nxp,pca9546";
> +                               reg = <0x72>;
> +                               #address-cells = <1>;
> +                               #size-cells = <0>;
> +                               i2c-mux-idle-disconnect;
> +
> +                               i2c6mux1ch0: i2c at 0 {
> +                                       reg = <0>;
> +                                       #address-cells = <1>;
> +                                       #size-cells = <0>;
> +                               };
> +                               i2c6mux1ch1: i2c at 1 {
> +                                       reg = <1>;
> +                                       #address-cells = <1>;
> +                                       #size-cells = <0>;
> +
> +                                       voltage-sensor at 48 {
> +                                               compatible = "ti,ads7830";
> +                                               reg = <0x48>;
> +                                       };
> +
> +                                       voltage-sensorr at 49 {
> +                                               compatible = "ti,ads7830";
> +                                               reg = <0x49>;
> +                                       };
> +
> +                                       temperature-sensor at 4a {
> +                                               compatible = "ti,tmp175";
> +                                               reg = <0x4a>;
> +                                       };
> +
> +                                       temperature-sensor at 4b {
> +                                               compatible = "ti,tmp175";
> +                                               reg = <0x4b>;
> +                                       };
> +
> +                                       eeprom at 56 {
> +                                               compatible = "atmel,24c256";
> +                                               reg = <0x56>;
> +                                       };
> +                               };
> +                               i2c6mux1ch2: i2c at 2 {
> +                                       reg = <2>;
> +                                       #address-cells = <1>;
> +                                       #size-cells = <0>;
> +                               };
> +                               i2c6mux1ch3: i2c at 3 {

Can you please make sure nodes consistently have empty lines between
them? Bunching them together like you have above degrades the
readability in my opinion.

Please audit the rest of the patch for the problem. Ideally audit the
rest of the devicetree too and send a follow-up patch fixing further
instances.

Andrew