[PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells range

Krzysztof Kozlowski krzk at kernel.org
Mon Oct 20 17:39:38 AEDT 2025


On 20/10/2025 08:31, Ryan Chen wrote:
>> Subject: Re: [PATCH] dt-bindings: mfd: aspeed,ast2x00-scu: allow #size-cells
>> range
>>
>> On 20/10/2025 04:07, Ryan Chen wrote:
>>> The #size-cells property in the Aspeed SCU binding is currently fixed
>>> to a constant value of 1. However, newer SoCs (ex. AST2700) may
>>> require two size cells to describe certain subregions or
>>
>> "may"? So there is no issue yet?
> 
> while I submit ast2700 platform,

So there is no warning currently? Then don't mention. You cannot use
argument of possible future warning as there is a warning needing to be
fixed. This makes no sense. Like you add bug in your patchset and then
send *different* patch claiming you are fixing a bug.


> These warnings appear when validating the AST2700 EVB device tree.
> The SCU nodes on AST2700 have subdevices (such as clock and reset controllers)
> that require two address cells, which is not allowed by the current `const: 1`
> constraint in the schema. 
> 
> Here is the related report:
>   https://lkml.org/lkml/2025/9/2/1165

This must be together, so we can review entire picture, not pieces by
pieces. Organize your work correctly, so reviewing will be easy.

Best regards,
Krzysztof


More information about the Linux-aspeed mailing list