[PATCH v4 11/13] ARM: dts: aspeed: facebook-fuji: Include facebook-fuji-data64.dts

[Guenter Roeck]

On 10/14/25 05:08, Andrew Lunn wrote:
> On Mon, Oct 13, 2025 at 06:15:27PM -0700, Tao Ren wrote:
>> Hi Guenter,
>>
>> On Mon, Oct 13, 2025 at 05:20:57PM -0700, Guenter Roeck wrote:
>>> Hi,
>>>
>>> On Sun, Jul 27, 2025 at 10:56:13PM -0700, rentao.bupt at gmail.com wrote:
>>>> From: Tao Ren <rentao.bupt at gmail.com>
>>>>
>>>> Include "facebook-fuji-data64.dts" in facebook-fuji dts to avoid
>>>> duplicated code.
>>>>
>>>> Fuji-data64 and Fuji are identical except the BMC flash layout.
>>>>
>>>> Signed-off-by: Tao Ren <rentao.bupt at gmail.com>
>>>
>>> With this patch in the mainline kernel, the Ethernet interface I use for
>>> testing does not come online when loading fuji-bmc in qemu.
>>>
>>> Reverting this patch fixes the problem.
>>>
>>> Looking into this patch,
>>>
>>>> -
>>>> -#include <dt-bindings/leds/common.h>
>>>> -#include "ast2600-facebook-netbmc-common.dtsi"
>>>> +#include "aspeed-bmc-facebook-fuji-data64.dts"
>>>>   
>>> ...
>>>> -&mac3 {
>>>> -	status = "okay";
>>>> -	phy-mode = "rgmii";
>>>> -	phy-handle = <&ethphy3>;
>>>> -	pinctrl-names = "default";
>>>> -	pinctrl-0 = <&pinctrl_rgmii4_default>;
>>>> -};
>>>
>>> I don't see this in aspeed-bmc-facebook-fuji-data64.dts, meaning that
>>> interface is now disabled. Adding it back in fixes the problem.
>>> Also, MAC3 is explicitly enabled for fuji-bmc in qemu.
>>>
>>> Was the interface disabled on purpose ?
>>>
>>> Thanks,
>>> Guenter
>>
>> The mac3 interface was removed in the latest patch (v4) per Andrew Lunn's
>> feedback, because the rgmii setting is incorrect.
>>
>> I was planning to add mac3 back as soon as rgmii support is properly
>> handled in aspeed mac driver, but kindly let me know if you have other
>> suggestions.
> 
> If it is already in mainline, i don't care too much if it is wrong. We
> don't want to cause regressions.
> 
> I only object when adding new nodes which are wrong. If we keep adding
> broken nodes, there is no incentive to fix the broken driver to do the

This wasn't adding an allegedly (sorry, it worked for me) broken node,
it was removing one that worked for me all along. Obviously I do not know
if it worked (or if it is even used) on real hardware, but it worked for
the fuji-bmc qemu emulation.

Guenter