[PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

Jacky Chou jacky_chou at aspeedtech.com
Fri Nov 7 14:28:18 AEDT 2025


> > > > There are four MACs in the AST2600. In the DT bindings and DTS
> > > > files, what would be the recommended way to identify which MAC is
> which?
> > > > In version 3 of my patches, I used the aliases in the DTSI file to
> > > > allow the driver to get the MAC index.
> > >
> > > It is a bit ugly, but you are working around broken behaviour, so
> > > sometimes you need to accept ugly. The addresses are fixed. You know
> > > 1e660000 is mac0, 1e680000 is mac1, etc. Put the addresses into the
> > > driver, for compatible aspeed,ast2600-mac.
> > >
> >
> > I used this fixed address as MAC index in the first version of this series.
> > But the other reviewer mentioned maybe there has the other better way
> > to identify index.
> > https://lore.kernel.org/all/20250317095229.6f8754dd@fedora.home/
> > I find the "aliase", on preparing the v2 and v3, I think it may be a
> > way to do that. But I am not sure.
> > So, I would like to confirm the other good way before submitting the
> > next version.
> 
> The problem with alias is that it normally a board property, in the .dts file. A
> board might want a different mapping, which could then break delays.
> 

Agreed. I looked through ethernet-controller.yaml, but it doesn't seem to have 
any property that fits our needs.
I will use the fixed-address value from the reg property to identify the index of 
MACs to configure the RGMII delay in next version.

Thanks,
Jacky


More information about the Linux-aspeed mailing list