[PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

Jacky Chou jacky_chou at aspeedtech.com
Tue Nov 4 20:54:56 AEDT 2025


Hi Krzysztof

Thank you for your reply.

> > Create the new compatibles to identify AST2600 MAC0/1 and MAC3/4.
> > Add conditional schema constraints for Aspeed AST2600 MAC controllers:
> > - For "aspeed,ast2600-mac01", require rx/tx-internal-delay-ps properties
> >   with 45ps step.
> > - For "aspeed,ast2600-mac23", require rx/tx-internal-delay-ps properties
> >   with 250ps step.
> 
> That difference does not justify different compatibles. Basically you said they
> have same programming model, just different hardware characteristics, so
> same compatible.
> 

This change was originally based on feedback from a previous review discussion.
At that time, another reviewer suggested introducing separate compatibles for 
MAC0/1 and MAC2/3 on AST2600, since the delay characteristics differ and they 
might not be fully compatible.

Thanks,
Jacky



More information about the Linux-aspeed mailing list