回覆: [PATCH net-next v3 1/4] dt-bindings: net: ftgmac100: Add delay properties for AST2600

[Jacky Chou]

> > diff --git
> > a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > index d14410018bcf..de646e7e3bca 100644
> > --- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > +++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
> > @@ -19,6 +19,12 @@ properties:
> >                - aspeed,ast2500-mac
> >                - aspeed,ast2600-mac
> 
> I don't know if it is possible, but it would be good to mark aspeed,ast2600-mac
> as deprecated.
> 
> I also think some comments would be good, explaining how
> aspeed,ast2600-mac01 and aspeed,ast2600-mac23 differ from
> aspeed,ast2600-mac, and why you should use them.
> 

Thanks for the suggestion.
We keep "aspeed,ast2600-mac" in the compatible list mainly for backward compatibility.
There are already many existing device trees and systems using this string.
Removing or deprecating it right now might break those setups.

However, I agree that adding comments to clarify the differences between "aspeed,ast2600-mac",
"aspeed,ast2600-mac01", and "aspeed,ast2600-mac23" would be helpful for new users. 

In the future, if someone submits a new DTS for an AST2600-based platform,
I think they should add the new compatible string and properly describe the TX/RX delay and 
phy-mode properties in their DTS.

Thanks,
Jacky