[PATCH net-next v3 4/4] net: ftgmac100: Add RGMII delay support for AST2600

Jacky Chou jacky_chou at aspeedtech.com
Tue Nov 4 15:47:16 AEDT 2025


Hi Andrew,

Thank you for your reply.

> > +	rgmii_tx_delay = DIV_ROUND_CLOSEST(rgmii_tx_delay,
> rgmii_delay_unit);
> > +	if (rgmii_tx_delay >= 32) {
> > +		dev_err(&pdev->dev,
> > +			"The index %u of TX delay setting is out of range\n",
> > +			rgmii_tx_delay);
> 
> The index is not really interesting here, it is not something a DT author uses. It
> is the delay in ps in the .dts file which is too big.
> 

Agreed - the "index" isn't meaningful to DT authors.
I'll modify the error message to display the actual TX/RX delay value in picoseconds 
instead of the internal index, so it's clearer which DT value is too large.

Thanks,
Jacky



More information about the Linux-aspeed mailing list