[PATCH 14/17] pinctrl: renesas: Move fixed assignments to 'pinctrl_desc' definition
Krzysztof Kozlowski
krzysztof.kozlowski at linaro.org
Thu May 29 03:55:07 AEST 2025
On 28/05/2025 14:54, Geert Uytterhoeven wrote:
>> .pmxops = &rzn1_pmx_ops,
>> .confops = &rzn1_pinconf_ops,
>> .owner = THIS_MODULE,
>> + .pins = rzn1_pins,
>> + .npins = ARRAY_SIZE(rzn1_pins),
>> };
>>
>> static int rzn1_pinctrl_parse_groups(struct device_node *np,
>> @@ -878,8 +880,6 @@ static int rzn1_pinctrl_probe(struct platform_device *pdev)
>>
>> ipctl->dev = &pdev->dev;
>> rzn1_pinctrl_desc.name = dev_name(&pdev->dev);
>
> ... if you would replace this assignment by a hardcoded name
> like "pinctrl-rzn1".
I saw it, but this would not be equivalent. dev_name includes platform
bus id, e.g. pinctrl-rzn1.0 which might matter here - conflict of names.
Are you sure this would work fine?
Best regards,
Krzysztof
More information about the Linux-aspeed
mailing list